Skip to content
This repository was archived by the owner on Dec 6, 2024. It is now read-only.

Added volume controller style events package #68

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Added volume controller style events package #68

merged 2 commits into from
Feb 8, 2024

Conversation

shanduur
Copy link
Contributor

@shanduur shanduur commented Nov 30, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 30, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @shanduur. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 30, 2023
This was referenced Nov 30, 2023
Merged
Merged
@shanduur shanduur changed the title feat(events): added CSI style events package Added volume controller style events package Nov 30, 2023
@shanduur
Copy link
Contributor Author

shanduur commented Dec 1, 2023 •
edited
Loading

@wlan0 @BlaineEXE please take a look, if that's ok. Referenced PRs have the code updated (no go.mod change though).

@shanduur
fix(review/1): event reasons
5950cb6 
Signed-off-by: Mateusz Urbanek <[email protected]>
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@shanduur
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 31, 2024
@shanduur shanduur requested a review from BlaineEXE February 5, 2024 15:11
BlaineEXE
BlaineEXE approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@BlaineEXE BlaineEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good to merge.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BlaineEXE, shanduur, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BlaineEXE
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0544427 into kubernetes-retired:master Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wlan0 wlan0 wlan0 approved these changes

@BlaineEXE BlaineEXE BlaineEXE approved these changes

@saad-ali saad-ali Awaiting requested review from saad-ali

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@BlaineEXE BlaineEXE

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shanduur @k8s-ci-robot @BlaineEXE @wlan0